replit / desktop

Replit Desktop App
116 stars 7 forks source link

Make createWindow synchronous + grab first window on deeplink #111

Closed sergeichestakov closed 1 year ago

sergeichestakov commented 1 year ago

Why

Main motivation is to prevent a redundant window from opening up when the app is opened via Deeplink (see Linear). e.g. if you open a replit://home link which launches the app you should see only one window with the home screen pop up not a home screen window and another window with your last Repl. Not sure if this fixes it but it's a good start to avoid race conditions between the onReady logic in main.ts and handling the first deeplink.

What changed

Make createWindow synchronous + grab 1st window on deeplink like we do when creating window.

Test plan

Deeplinks / creating windows should work as expected. The problem designed above is potentially fixed once packaged/released