search

replit / desktop

Replit Desktop App
116 stars 7 forks source link

Enable experimental-web-platform-features flag #128

Closed sergeichestakov closed 1 year ago

sergeichestakov commented 1 year ago

Why

In debugging the attached Linear task, I discovered that the filesystem/files web APIs do not work correctly in Electron unless this flag is enabled which means things like downloading pngs does not work as expected. See relevant open issue: https://github.com/electron/electron/issues/28422

Adding this flag fixes the issue and likely enables other Chromium features that we / deps we rely on might use. While the docs warn against using this feature, I don't see a convincing reason if it works for us, fixes issues like this, and especially given that we control which content is loaded into the browser window.

Fixes WS-1076

What changed

Enable experimental-web-platform-features flag for the app

Test plan

Download as png works as expected in draw files in the app per the repro steps in the attached Linear task

linear[bot] commented 1 year ago
WS-1076 saving excalidraw documents as pngs does not work

sam said: > saving excalidraw documents as pngs does not work [Screenshot 2023-09-18 at 9.24.14 AM.png](https://uploads.linear.app/c5cab91b-5d7a-4b49-b62c-fe245c567e3b/04ac7a9e-2449-4e49-a121-63ab0ead4c5f/8b19ea68-3c85-4b6a-8af6-b90b0b557c9b)