We switched to M1 machines in this PR: https://github.com/replit/desktop/pull/136 but we weren't actually signing them in CI during the publish step since we only generate the cert on the macOS-latest machine whereas we should actually generate it in macOS-13-xlarge as well otherwise the app will fail to sign since the cert will not be present on the machine.
Additionally, we should also run the sign step in CI during the "build" workflow. I was originally avoiding this since it takes quite a bit longer but a couple extra minutes per build is worth it since it better matches our publish step and can help us find bugs related to signing like this before we go to publish.
What changed
Sign apps with build workflow by passing in all the relevant env vars like we do in publish workflow
Generate certs for M1 Macs too during build and publish
Fix typo in workflows/** directory
Test plan
Build passes (particularly on Mac and Windows) and the app is signed
Why
We switched to M1 machines in this PR: https://github.com/replit/desktop/pull/136 but we weren't actually signing them in CI during the publish step since we only generate the cert on the
macOS-latestmachine whereas we should actually generate it inmacOS-13-xlargeas well otherwise the app will fail to sign since the cert will not be present on the machine.Additionally, we should also run the sign step in CI during the "build" workflow. I was originally avoiding this since it takes quite a bit longer but a couple extra minutes per build is worth it since it better matches our publish step and can help us find bugs related to signing like this before we go to publish.
What changed
workflows/**directoryTest plan
Build passes (particularly on Mac and Windows) and the app is signed