replit / desktop

Replit Desktop App

116 stars 7 forks source link

Add vscode:// and replit:// to external protocol allowlist #151

Closed sergeichestakov closed 8 months ago

sergeichestakov commented 8 months ago

Why

We want replit:// links to work in the app for obvious reasons (e.g. performing actions or opening new windows via links) and also want to support vscode:// URLs explicitly so that the new "Open in VS Code" button and relevant SSH functionality works as expected (see attached Linear task).

Fixes WS-3018

What changed

Add vscode:// and replit:// to external protocol allowlist

Test plan

Open replit:// and/or vscode:// links from the app -> works
New "Open in VS Code" button works as expected in the desktop app
Opening http(s) external links still works as expected in the app

linear[bot] commented 8 months ago

WS-3018 Open in VS Code doesn't work in the desktop app

We block you from opening custom (non http(s)) URIs so the `vscode://` URL fails to open with no indication of what went wrong.