search

replit / desktop

Replit Desktop App
114 stars 3 forks source link

Log when openExternal is called in window event handlers #153

Closed sergeichestakov closed 6 months ago

sergeichestakov commented 6 months ago

Why

We've been seeing a bug in the app where a certain repl or tab will be opened in your browser while the app is running in the background. I'm not sure why this happens tbh and can't find any logs from those that have reported this issue in Datadog (which is where we log when we open external URLs on the web side) so we should add some logging on the native side too to help us investigate. See attached Linear issue and Slack thread for more detail.

references WS-2021

What changed

Log when openExternal is called in window event handlers. Also replacing a use of the deprecated navigationUrl param while I'm at it

Test plan

linear[bot] commented 6 months ago
WS-2021 Replit desktop application bug: Somehow I got unauthenticated in the desktop app, while the app w...

devon.stewart said: > Replit desktop application bug: Somehow I got unauthenticated in the desktop app, while the app was in the background. > • The desktop app did not acknowledge that it was logged out, but it did trigger opening the current repl in a new tab in the browser, which stole focus from my Terminal (It just happened again as I'm typing this, taking focus from Slack!) > • The desktop app did not indicate that I was logged out until I clicked "Account" in the user's hamburger menu, but now I'm stuck in loading screen purgatory, even though every few minutes a new tab is spawned.