replit / desktop

Replit Desktop App
114 stars 3 forks source link

Update x64/Arm Mac runners in GH Actions #155

Closed sergeichestakov closed 5 months ago

sergeichestakov commented 5 months ago

Why

I found out today that the macos-latest GH actions runner got switched out from under our feet in the past month since we last published and now the machine that runs those actions is an Apple Silicon (ARM) chip instead of an older Intel-based Mac. See relevant changelog: https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/

The implication of this is that now both our "x64" and "arm64" jobs in GH actions are, in fact, producing arm64 based artifacts.

What changed

Update x64/Arm Mac runners in GH Actions. Now, the macos-latest runner corresponds to Apple Silicon (ARM) machines, meaning we no longer need the xlarge runner, and the macOS-12 runner corresponds to Intel chip builds.

Test plan

Should produce 2 separate DMGs, one for each architecture, on next run 🤞 In the meantime, the "runner details" in the GH actions logs in CI should indicate that they are running on the appropriate architecture.