Only open windows externally if window is focused

[sergeichestakov]

Why

We've gotten some reports of the desktop app randomly opening pages when unfocused and in the background. I have a feeling this is due to some of our "openExternal" logic around redirecting non-Replit pages (or those not supported in the desktop app) to the user's browser instead. I'm not sure why this would be occurring in the background since this should usually only happen by the user clicking links or something triggering window.open but evidently it is. See Slack thread.

What changed

Only open external links in the user's browser if the window is actually focused. This will stop tabs from opening when the app is in the background.

Test plan

• Open external links by clicking a link or calling window.open in the console when the app is focused -> should still open external links in the browser
• Should stop getting reports of this happening when the app is unfocused though.

[sergeichestakov]

yes definitely a band-aid 😕 Not sure yet but will keep digging

[sergeichestakov]

corresponding web PR: https://github.com/replit/repl-it-web/pull/43941

[sergeichestakov]

FYI @szymonkaliski figured it out here: https://github.com/replit/repl-it-web/pull/44658