search

replit / desktop

Replit Desktop App
114 stars 3 forks source link

adjusting traffic light position #75

Closed omar-replit closed 1 year ago

omar-replit commented 1 year ago

Why

Adjusting header height/traffic light position values to match denser header height from repl-it-web

What changed

Test plan

omar-replit commented 1 year ago

Thank you, great point - it's not dependent on a flag, but just this PR merging: https://github.com/replit/repl-it-web/pull/34124

This is per our conversation on slack here: https://replit.slack.com/archives/C0509G0FJNL/p1689606082217349

sergeichestakov commented 1 year ago

gotcha ok, sg! lmk when you plan to land/deploy that and then we can merge this in and publish a new release

sergeichestakov commented 1 year ago

@omar-replit can you be more vocal next time? I just so happen to see that the web PR got merged and now deployed but we should have done a better job coordinating here since it takes time to do releases and I'd rather minimize the time where the traffic lights were misaligned in the app

omar-replit commented 1 year ago

I'm working with szymon on this!

omar-replit commented 1 year ago

And in this case, it seems you happened to check its deployment status within a minute or so of it actually being deployed, I don't think we lagged here

sergeichestakov commented 1 year ago

gotcha didn't realize you guys were talking. ideally this can be in a more public setting either in the PR or in the desktop-app channel but yeah it's all good here