replit / desktop

Replit Desktop App
116 stars 7 forks source link

Fix spelling of iconUrl in the Squirrel maker config #87

Closed sergeichestakov closed 1 year ago

sergeichestakov commented 1 year ago

Why

This is causing the Electron Icon to appear next to the app when listed in the "Programs and features" and "Installed apps" sections on Windows. Fixes WS-600

I thought I fixed this in https://github.com/replit/desktop/pull/37 but it turns out that I got the spelling wrong 🤦

Apparently, that's a fairly common issue: https://github.com/electron/forge/issues/2941#issuecomment-1261255135

What changed

Fix spelling of iconUrl in the Squirrel maker config

Test plan

Should see our own icon instead of Electron in those places after the next build

sergeichestakov commented 1 year ago

Screenshots for reference:

Screenshot 2023-07-28 at 3 39 59 PM Screenshot 2023-07-28 at 3 39 54 PM
linear[bot] commented 1 year ago
WS-600 Still seeing Electron icon in Windows launch menu

See [thread](https://discord.com/channels/1077728434064740405/1111756232940859392/1132692706041266237)

sergeichestakov commented 1 year ago

gonna go ahead and land this since it's a simple config change but feel free to do a retroactive review

sergeichestakov commented 1 year ago

confirmed this now works in the latest release:

Screenshot 2023-08-02 at 12 03 03 PM Screenshot 2023-08-02 at 12 01 53 PM