search

replit / kaboom

💥 JavaScript game library
https://kaboomjs.com
MIT License
2.66k stars 226 forks source link

fadeIn() now uses opacity to figure out the final opacity to fade into #844

Closed niceEli closed 4 months ago

niceEli commented 5 months ago

Changed fadeIn to use opacity so it can fade into 0.5 for example Changed Contributing.md because there was "" around linebreak style and that isnt correct Added fadeIn example so you can learn fadeIn Changed JSDoc to have a fadeIn example

niceEli commented 5 months ago

no clue how to rebase so ill close and make a new PR

niceEli commented 5 months ago

nvm turns out it auto rebases ig

reimertz commented 4 months ago

this would be a welcome addition! Was just trying to figure out how to do this.

lajbel commented 4 months ago

can you add a changelog for this before merge?

reimertz commented 4 months ago

@lajbel you mean me? I can fork this and create a new PR if you want.

Should add changes under version v3000.2.1? if So

## v3000.2.1
- fixed `fadeIn()` not properly using `opacity()`

Also, would this be considered a breaking change since all users who specify opacity(), then fadeIn() now will see the opacity actually being applied.

lajbel commented 4 months ago

I was referring to the PR owner, but thank you! Good point