add Lua 5.3 - Githubissues

replit / polygott

Base Docker image for the Repl.it evaluation server

https://replit.com

MIT License

395 stars 103 forks source link

add Lua 5.3 #156

Closed s-ol closed 1 year ago

s-ol commented 4 years ago

This is mostly a copy of the Lua 5.1 setup, with these changes:

luaformatter and metalua are removed because they don't support 5.1
prybar is not built since it doesn't appear to support Lua 5.3 (currently)

If possible, I'd be very happy to see this merged soon in order to proceed with the language jam :wink:

ALANVF commented 4 years ago

Rather than not building Prybar (due to the version issue), why not make a PR to Prybar as well?

s-ol commented 4 years ago

@ALANVF: I didn't quite understand the role of Prybar in the ecosystem, and I didn't have much time to play around today. So when the tests passed and everything looked clean I let it be for today. I can try to do a similar PR in the prybar repo as well tomorrow, but I am unsure how to test whether prybar is built and installed correctly inside the polygott image.

s-ol commented 4 years ago

Ok, I submitted PR replit/prybar#56 as well.

dan-stowell commented 4 years ago

Good afternoon @s-ol ! You've probably noticed by now that we've been slow to merge community PRs on polygott. We've decided to focus on giving Repl.it a stable foundation instead of adding features and updating languages. Once we and our community feel comfortable with Repl.it's overall stability, we'll give this change another look. Thank you for contributing!