Closed amasad closed 4 years ago
In the current implementation, instanceof fails because we get classes like Array and Object from a different realm.
instanceof
Array
Object
With this, we only copy things that are missing from the context (and the console).
This is implementing https://github.com/replit/goval/pull/1419
Good work, this PRs short and easy to review! Promoting to bop.
bop
unbooping: changes requested. Make sure to address everyone's comments and dismiss any reviews before booping.
In the current implementation,
instanceof
fails because we get classes likeArray
andObject
from a different realm.With this, we only copy things that are missing from the context (and the console).
This is implementing https://github.com/replit/goval/pull/1419