search

replit / upm

⠕ Universal Package Manager - Python, Node.js, Ruby, Emacs Lisp.
https://repl.it
Other
1.05k stars 89 forks source link

chore(flake): update build-go-cache for less rebuild #274

Closed zimbatm closed 1 month ago

zimbatm commented 1 month ago

Why

This is a small developer UX issue. In some cases, Nix would rebuild instead of fetching the result from the binary cache.

What changed

https://github.com/numtide/build-go-cache/pull/9

Thanks to katexochen for fixing this issue.

Test plan

Describe what you did to test this change to a level of detail that allows your reviewer to test it

katexochen commented 1 month ago

@zimbatm there is actually a workaround in place to prevent the rebuilds in another way (the comment pointed me to the problem in the first place):

https://github.com/replit/upm/blob/91c21f5ca1ae1e664f9c288515e332517c385f6d/nix/upm/default.nix#L16-L20

This could be removed now. :)

blast-hardcheese commented 1 month ago

Based on the conversation here it seems this is not necessary, closing this out for now but please feel free to follow up if I misunderstood. Thank you!