replit / upm

⠕ Universal Package Manager - Python, Node.js, Ruby, Emacs Lisp.
https://repl.it
Other
1.05k stars 89 forks source link

bug/Only force needsPackageDir if we have packages to install #280

Closed blast-hardcheese closed 1 month ago

blast-hardcheese commented 1 month ago

Why

We've been having a regression on metrics for zero-package installs, turns out it's because we were invoking poetry when we had no work to do.

What changed

Gate needsPackageDir on whether we have packages to install. No sense in doing work when we don't need to.

Test plan

We should see the time-to-install go down after this is deployed