Be smarter about minimum threshold so that a large part of the map is not "Other"

[askyel]

add 'maxOtherSize' prop - how much of total other section should take up, recompute otherThreshold using it, prop type error if otherThreshold added as well

changing minThreshold doesn't work beyond a point due to rounding errors? e.g. .00001

fix rounding error in otherThreshold, a bunch of things go into other no matter how small the threshold

missing name, data where country is NULL -> drop nulls from being rendered (check at beginning if any of the keys are null)

[sanjaypojo]

Hey @askyel, I'm working on this issue FYI!

[AlmahaAlmalki]

@sanjaypojo @askyel did we add a new prop for the "total minimum threshold" to ensure that a large part of the map is not other?

[sanjaypojo]

Yes, I added and pushed this - the props are maxOtherSize and otherThreshold. @AlmahaAlmalki , let me know if it's working for you

[AlmahaAlmalki]

@sanjaypojo I tried the new prop, I'm not sure if it's not working or if I'm doing something wrong.

So in this example, I want anything less than or equal 2% to belong to other, but other should not exceed 5% of the total treemap size.

[sanjaypojo]

Hi @AlmahaAlmalki, you're right, at the moment, only otherThreshold works. maxOtherSize is yet to be pushed. I'll do it now and comment once it's pushed so that you can check!

[sanjaypojo]

@AlmahaAlmalki, just made the fix, see if it works for you. If you set maxOtherSize it should behave the right way 😸

[AlmahaAlmalki]

@sanjaypojo it's working perfectly, thanks