Closed alamirault closed 2 years ago
alamirault
commented
2 years ago With no use of deprectaed getUsername method coverage is now bellow 99%
Code coverage is 98.87%, which is below the accepted 99%
Should I add an unit test on getUsername ?
akondas
commented
2 years ago Should I add an unit test on getUsername ?
Yes please (in fact, this coverage is mainly for checking open source PR) ... or you can also lower it to 98% :shrug:
codecov[bot]
commented
2 years ago Merging #531 (fb8b9cd) into master (3e26961) will decrease coverage by
0.11%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #531 +/- ##
============================================
- Coverage 99.33% 99.21% -0.12%
Complexity 1893 1893
============================================
Files 301 301
Lines 6013 6014 +1
============================================
- Hits 5973 5967 -6
- Misses 40 47 +7 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/Command/ProxySyncReleasesCommand.php | 100.00% <100.00%> (ø) |
|
| src/Repository/UserRepository.php | 100.00% <100.00%> (ø) |
|
| src/Security/Model/Organization.php | 100.00% <100.00%> (ø) |
|
| src/Security/Model/User.php | 100.00% <100.00%> (ø) |
|
| src/Security/OAuthAuthenticator.php | 100.00% <100.00%> (ø) |
|
| src/Service/Twig/DateExtension.php | 97.82% <100.00%> (ø) |
|
| src/Security/OrganizationProvider.php | 84.61% <0.00%> (-12.83%) |
:arrow_down: |
| src/Security/UserProvider.php | 94.59% <0.00%> (-5.41%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3e26961...fb8b9cd. Read the comment docs.
akondas
commented
2 years ago Big thanks @alamirault :beers:
Phpstan 1.0.0 was released in november.
This PR use last version !
We may also add
@deprecatedannotation ongetUsernamemethods . It's deprecated in UserInterface since sf 5.3 in favor of getUserIdentifier()