repman-io / repman

Repman - PHP Repository Manager: packagist proxy and host for private packages
https://repman.io
MIT License
515 stars 107 forks source link

Update symfony from 5.3 to 5.4 #543

Closed xvilo closed 2 years ago

xvilo commented 2 years ago

Active support for Symfony 5.3 ended 6 days ago (01 Jan 2022). Symfony 5.4 was released 1 month and 1 week ago (29 Nov 2021) and it's support ends in 2 years and 10 months (30 Nov 2024).

codecov[bot] commented 2 years ago

Codecov Report

Merging #543 (a7dee37) into master (322570d) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #543   +/-   ##
=========================================
  Coverage     99.33%   99.33%           
  Complexity     1893     1893           
=========================================
  Files           301      301           
  Lines          5996     6013   +17     
=========================================
+ Hits           5956     5973   +17     
  Misses           40       40           
Impacted Files Coverage Δ
src/Command/ClearMetadataCacheCommand.php 100.00% <100.00%> (ø)
src/Command/ProxySyncMetadataCommand.php 100.00% <100.00%> (ø)
src/Command/ProxySyncReleasesCommand.php 100.00% <100.00%> (ø)
src/Command/ScanAllPackagesCommand.php 100.00% <100.00%> (ø)
src/Command/SynchronizeAllPackagesCommand.php 100.00% <100.00%> (ø)
src/Command/SynchronizePackageCommand.php 100.00% <100.00%> (ø)
src/Command/UpdateAdvisoriesDbCommand.php 100.00% <100.00%> (ø)
src/Controller/Admin/ConfigController.php 100.00% <100.00%> (ø)
src/Controller/Admin/OrganizationController.php 100.00% <100.00%> (ø)
src/Controller/Admin/ProxyController.php 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 322570d...a7dee37. Read the comment docs.

xvilo commented 2 years ago

PHPUnit is ✅ was also able to do some stuff locally on my development machine. So I suspect this PR is fine 👍

xvilo commented 2 years ago

@akondas pushed the last change to address your comment, all should be fine now :)

akondas commented 2 years ago

Thanks @xvilo :beers: