search

repman-io / repman

Repman - PHP Repository Manager: packagist proxy and host for private packages
https://repman.io
MIT License
515 stars 107 forks source link

Fix detection of latest stable release (fix #443) #562

Closed blmage closed 1 year ago

blmage commented 2 years ago

If the first fetched package is not stable, but has a greater version than any of the stable packages, wrong behaviors such as that reported in #443 may occur.

codecov[bot] commented 2 years ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b463a21) 99.04% compared to head (3d2a678) 99.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #562 +/- ## ========================================= Coverage 99.04% 99.04% - Complexity 1910 1912 +2 ========================================= Files 301 301 Lines 6075 6079 +4 ========================================= + Hits 6017 6021 +4 Misses 58 58 ``` | [Impacted Files](https://codecov.io/gh/repman-io/repman/pull/562?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=repman-io) | Coverage Δ | | |---|---|---| | [...ackageSynchronizer/ComposerPackageSynchronizer.php](https://codecov.io/gh/repman-io/repman/pull/562?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=repman-io#diff-c3JjL1NlcnZpY2UvUGFja2FnZVN5bmNocm9uaXplci9Db21wb3NlclBhY2thZ2VTeW5jaHJvbml6ZXIucGhw) | `97.08% <100.00%> (+0.08%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

giggsey commented 2 years ago

Can I help with this to get it over the line?

akondas commented 1 year ago

sorted in #617 feel free to reopen if I make false assumptions :wink: