Open shochdoerfer opened 2 years ago
Merging #591 (7b8b6a2) into master (8b1d42e) will decrease coverage by
0.02%
. The diff coverage is96.49%
.
@@ Coverage Diff @@
## master #591 +/- ##
============================================
- Coverage 99.14% 99.11% -0.03%
- Complexity 1910 1923 +13
============================================
Files 301 304 +3
Lines 6072 6117 +45
============================================
+ Hits 6020 6063 +43
- Misses 52 54 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/Query/Api/Model/Organization.php | 90.90% <60.00%> (-9.10%) |
:arrow_down: |
src/Controller/Organization/PackageController.php | 100.00% <100.00%> (ø) |
|
src/Controller/OrganizationController.php | 100.00% <100.00%> (ø) |
|
src/Entity/Organization.php | 100.00% <100.00%> (ø) |
|
.../Form/Type/Organization/EnableSecurityScanType.php | 100.00% <100.00%> (ø) |
|
src/Message/Organization/AddPackage.php | 100.00% <100.00%> (ø) |
|
...e/Organization/ChangeSecurityScanConfiguration.php | 100.00% <100.00%> (ø) |
|
.../MessageHandler/Organization/AddPackageHandler.php | 100.00% <100.00%> (ø) |
|
...Handler/Organization/EnableSecurityScanHandler.php | 100.00% <100.00%> (ø) |
|
...ry/Api/OrganizationQuery/DbalOrganizationQuery.php | 100.00% <100.00%> (ø) |
|
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8b1d42e...7b8b6a2. Read the comment docs.
Any update on this?
good question ;) Sadly I completely lost track of this issue due to a lot of other things I had to focus on.
Let me know which of the findings need to be fixed before the PR can be merged and I'll see that I can take care soonish.
As discussed in #575 introduce a setting for the organization to define the default for new packages.
When a new organization is created the default value for the![scan](https://user-images.githubusercontent.com/596449/169642219-3ef4fc1a-e370-4792-b717-0a23b4cd4afc.png)
enable_security_scan
configuration is true to stick to the previous defaults. The setting can be changed afterward in the respective form like this:When a new package is created the default value for
enable_security_scan
flag on the package level is set to the value defined in the organization settings.As you can see in the screenshot above, changing the setting on the organization level does not change the settings for all packages of that organization. It just will change the default value for newly created packages.