Open xvilo opened 1 year ago
Merging #608 (180897b) into master (f82251f) will decrease coverage by
0.01%
. The diff coverage is96.96%
.
@@ Coverage Diff @@
## master #608 +/- ##
============================================
- Coverage 99.16% 99.14% -0.02%
- Complexity 1910 1917 +7
============================================
Files 301 303 +2
Lines 6072 6092 +20
============================================
+ Hits 6021 6040 +19
- Misses 51 52 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/Controller/RepoController.php | 98.70% <95.00%> (-1.30%) |
:arrow_down: |
src/Service/Composer/ComposerEnvironment.php | 100.00% <100.00%> (ø) |
|
...rc/Service/Composer/ComposerEnvironmentFactory.php | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Possible todo: add test for composer v1 and V2 package endpoint differences. Also test this with an invalid user agent. This will fix the missing coverage
I'm willing to accept this ... but can you add more tests for that? I'm not sure if i'm follow (sorry) and tests will give me more confidence :wink:
Currently, Repman is quite slow on the
/packages.json
endpoint, this due it's requesting all JSON files for every package from S3. From composer 2.0 and onwards, the API has been changed, it does not need to have all packages available any more. But, it now may provide theproviders-url
andmetadata-url
. This is where information for a specific package can be found. Thus, it does not have to wait for all packages to be resolved AND it's able to request info about the needed packages only.If people are still using composer 1.0 it will add back the old data, so performance impact will only be solved for people using v2. It will however, show an extra warning.
Curl request statistics for
/packages.json
repo endpoint:Currently:
with these changes:
Looking at the total request time for our internal production deployment, we're going from a request time of 24 seconds, to around 260 milliseconds.