Fix no stable release sorting bug

marickvantuil commented 2 years ago

This fixes the issue in #562 where if the first fetched package is not stable, then no stable release can be determined because the version comparison will fail with Comparator::greaterThan.

marickvantuil commented 2 years ago

Not sure why the Buddy build is failing, let me know if I can do something to fix it. 👍

aleho commented 1 year ago

This actually fixes the issue on my installation.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b463a21) 99.04% compared to head (8373ebd) 99.04%.

:exclamation: Current head 8373ebd differs from pull request most recent head c5f25d4. Consider uploading reports for the commit c5f25d4 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #617 +/- ## ========================================= Coverage 99.04% 99.04% - Complexity 1910 1914 +4 ========================================= Files 301 301 Lines 6075 6079 +4 ========================================= + Hits 6017 6021 +4 Misses 58 58 ``` | [Impacted Files](https://codecov.io/gh/repman-io/repman/pull/617?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=repman-io) | Coverage Δ | | |---|---|---| | [...ackageSynchronizer/ComposerPackageSynchronizer.php](https://codecov.io/gh/repman-io/repman/pull/617?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=repman-io#diff-c3JjL1NlcnZpY2UvUGFja2FnZVN5bmNocm9uaXplci9Db21wb3NlclBhY2thZ2VTeW5jaHJvbml6ZXIucGhw) | `97.08% <100.00%> (+0.08%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

repman-io / repman

Fix no stable release sorting bug #617

Codecov Report