Closed notorious-gay closed 4 years ago
Wow thanks so much for the PR! Instead of adding bash
as a dependency, we could just use grep
regex match.
if ! echo $UPSTREAM_REPO | grep -Eq ':|@|\.git\/?$'
then
UPSTREAM_REPO="https://github.com/${UPSTREAM_REPO}.git"
fi
Also updated the regex a bit to cover something like host.xz:/path/to/repo
too.
If you don't mind, could you pls review my change and perform some quick tests with the url examples you provided above?
No worries, I'll give this a try and get back to you!
All passed and running correctly on my test repo, looks like we're good to go! ๐
@all-contributors please add @GlitchShtick for bugs
@wei
I've put up a pull request to add @GlitchShtick! :tada:
@GlitchShtick It's been released and accessible via v2.1.3
and v2
. Thanks for the help!!! ๐
No worries at all! ๐
This allows the user to use this action to pull a glitch.com repo to GitHub as they too do not use the .git suffix :+1: (As well as many other origins thanks to @wei's suggestion!)
After wrangling with docker and GitHub not running the action correctly I've got this working, please note the following additional changes had to be made to get the regex to work:
Please let me know if you have any questions or suggestions ๐
This change has been tested to work with the following URI's: