Closed tohanss closed 3 years ago
Merging #136 (2fd6ff2) into master (56bc6be) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #136 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 253 255 +2
Branches 43 43
=========================================
+ Hits 253 255 +2
Impacted Files | Coverage Δ | |
---|---|---|
repobee_sanitizer/_sanitize.py | 100.00% <100.00%> (ø) |
|
repobee_sanitizer/_syntax.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 56bc6be...2fd6ff2. Read the comment docs.
Looks good at first glance, I want to try to break it a bit though. I'll try to get back to this during the weekend, been crunching too much at work the past few days to have after-work energy :)
Oh, and this is actually a breaking change, because before this whitespace counted as prefixes. So it should be marked [break]
.
That should just be removing the "format with black" commit, and creating a new branch with the formatting based of master right?
That should just be removing the "format with black" commit, and creating a new branch with the formatting based of master right?
First of all just do a new PR from master with the formatting changes, and merge that into master. Then just merge master into your two feature PRs. You'll get a few merge conflicts but they'll be easy tor resolve.
Should this have a [docs] tags as well as [break]?
Should this have a [docs] tags as well as [break]?
No, just pick the one that's most important. Any feature change naturally has documentation changes as well, but the important part is the feature change.
Prefixes in replace blocks and on markers can now be played anywhere regardless of whitespace
Fix #129