repobee / repobee-sanitizer

A plugin for sanitizing master repositories before distribution to students
MIT License
2 stars 3 forks source link

[break] Remove space from prefixes #136

Closed tohanss closed 3 years ago

tohanss commented 3 years ago

Prefixes in replace blocks and on markers can now be played anywhere regardless of whitespace

Fix #129

codecov[bot] commented 3 years ago

Codecov Report

Merging #136 (2fd6ff2) into master (56bc6be) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          253       255    +2     
  Branches        43        43           
=========================================
+ Hits           253       255    +2     
Impacted Files Coverage Δ
repobee_sanitizer/_sanitize.py 100.00% <100.00%> (ø)
repobee_sanitizer/_syntax.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56bc6be...2fd6ff2. Read the comment docs.

slarse commented 3 years ago

Looks good at first glance, I want to try to break it a bit though. I'll try to get back to this during the weekend, been crunching too much at work the past few days to have after-work energy :)

slarse commented 3 years ago

Oh, and this is actually a breaking change, because before this whitespace counted as prefixes. So it should be marked [break].

tohanss commented 3 years ago

That should just be removing the "format with black" commit, and creating a new branch with the formatting based of master right?

slarse commented 3 years ago

That should just be removing the "format with black" commit, and creating a new branch with the formatting based of master right?

First of all just do a new PR from master with the formatting changes, and merge that into master. Then just merge master into your two feature PRs. You'll get a few merge conflicts but they'll be easy tor resolve.

tohanss commented 3 years ago

Should this have a [docs] tags as well as [break]?

slarse commented 3 years ago

Should this have a [docs] tags as well as [break]?

No, just pick the one that's most important. Any feature change naturally has documentation changes as well, but the important part is the feature change.