search

repobee / repobee-sanitizer

A plugin for sanitizing master repositories before distribution to students
MIT License
2 stars 3 forks source link

[feat] Implement SHRED marker #74

Closed tohanss closed 4 years ago

tohanss commented 4 years ago

If a file now contains a REPOBEE-SANITIZER-SHRED marker, the entire file will be removed from the file system.

This is possible using the Sanitize-file command but is most useful when working with repositories.

Fix #39 and fix #73

slarse commented 4 years ago

@tohanss You still must do this:

Pin the version number of repobee (i.e. specify it with == instead of >=) to 3.0.0-alpha.1 in setup.py and requirements/app.txt. Otherwise you will get flaky behavior in CI as 3.0.0-alpha.2 has breaking changes (see #72 )

Make sure CI passes and then request a review again.

tohanss commented 4 years ago

The last commit might give us a merge conflict but I can deal with that

slarse commented 4 years ago

@tohanss You pinned to the wrong version, you must pin to 3.0.0-alpha.1. alpha.2 is what you're fixing support for in another #76

~Alternatively, finish #76 first and merge it into this PR.~

I've merged #76 , so go ahead and sync this PR with master. That should solve the CI problems.

codecov[bot] commented 4 years ago

Codecov Report

Merging #74 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          199       228   +29     
  Branches        31        40    +9     
=========================================
+ Hits           199       228   +29
Impacted Files Coverage Δ
repobee_sanitizer/_sanitize.py 100.00% <100.00%> (ø)
repobee_sanitizer/_sanitize_file.py 100.00% <100.00%> (ø)
repobee_sanitizer/_sanitize_repo.py 100.00% <100.00%> (ø)
repobee_sanitizer/_syntax.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2e6656...ea5e614. Read the comment docs.