search

repocrypts / Validator

Client-side javascript validator library ports from Laravel 5.2
MIT License
46 stars 22 forks source link

Add delimiter to titleCase in extend method (Issue 38) #39

Closed Jao-Quin closed 3 years ago

Jao-Quin commented 3 years ago

PR to fix Issue 38

jfstn commented 3 years ago

Hello @Jao-Quin ! 👋

Can you add a test to the PR?

Jao-Quin commented 3 years ago

Hey @jfstn ! Totally new to GitHub, so I'm not sure exactly the place/format for tests, but I'll learn a bit and get back to it!

jfstn commented 3 years ago

Sure, take your time. You can find the current tests at ./test/validator.js.

Check package.json scripts aswell.

Jao-Quin commented 3 years ago

Added a test and ran it. First time using Jasmine - did I do it right?

jfstn commented 3 years ago

Hey @Jao-Quin 👋

Have you seen the code review?

Jao-Quin commented 3 years ago

Hey @jfstn!

Sorry for slow response - I saw it and been meaning to do it; work's just been busy and I moved to a different area of the code.

There's another issue with the Numeric validator excluding scientific notation. Fixed it locally; will try to post a separate PR soon.

I'll come back to the validation soon as I'm planning a custom 'exists' checker to see if data is in the database. Not yet sure if it will be too site-specific or if it can be generalised for a PR.

jfstn commented 3 years ago

Sure! Thank you for your response 😊

Jao-Quin commented 3 years ago

Oof, sorry again for the long delay. Glad you were able to merge!

jfstn commented 3 years ago

It’s fine. Thank you for your contribution. 🙂