search

repology / repology-webapp

Repology web application
https://repology.org
GNU General Public License v3.0
200 stars 26 forks source link

Add dark theme #221

Open vitaly-zdanevich opened 1 year ago

vitaly-zdanevich commented 1 year ago

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

vitaly-zdanevich commented 6 months ago

Can I implement this?

AMDmi3 commented 6 months ago

Sure, but you've wanted to ask whether it would be accepted, and that depends on the solution. Do you have a plan? Does bootstrap support it?

vitaly-zdanevich commented 6 months ago

I did not try with bootstrap, but I fount this - yes, looks like supported https://getbootstrap.com/docs/5.3/customize/color-modes/

AMDmi3 commented 6 months ago

That says "Added in v5.3". Repology uses bootstrap 3.

vitaly-zdanevich commented 6 months ago

Do you want to update the Bootstrap?

vitaly-zdanevich commented 6 months ago

...or what about to drop the Bootstrap? Why do we need it? UI is pretty simple. For the default colors/margins only?

AMDmi3 commented 6 months ago

...or what about to drop the Bootstrap?

I would definitely prefer to drop bootstrap - new versions have introduced visual (as opposed to semantic) classes like spacing utilities which is not right.

For the default colors/margins only?

No, it's used for everything so dropping it won't be trivial. The replacement should me manageable (BEM preferred), responsive stylesheet, with no regressions in accessibility and other features.

vitaly-zdanevich commented 6 months ago

Do you know some candidates?

AMDmi3 commented 6 months ago

Which candidates?

vitaly-zdanevich commented 6 months ago

To replace Bootstrap.

AMDmi3 commented 6 months ago

No. My plans were to use completely custom CSS.

vitaly-zdanevich commented 6 months ago

Hm, looks like its a lot of work, right?

AMDmi3 commented 6 months ago

Exactly. But maybe it can be done gradually

vitaly-zdanevich commented 4 months ago

So, how can I start?

AMDmi3 commented 4 months ago

Sorry, I cannot offer any guidance here.