search

reporangler / auth-service

A webservice to handle authentication for repository access
MIT License
0 stars 0 forks source link

Access Tokens should be given a type [php, npm, etc] #13

Closed christhomas closed 5 years ago

christhomas commented 5 years ago

I've realised the Access Token endpoints don't add a repository_type field, meaning a token is given for github, but we have no idea whether we should use that token for php packages or npm.

I'm not entirely sure whether it matters, but I'm just going to make a note of this here in case I need to think about it in the future

christhomas commented 5 years ago

The more I think about this, the more I don't think it matters, since github and gitlab could host php, or npm packages and they don't care what the repository type is.

christhomas commented 5 years ago

I'm not going to do this, it doesn't make sense, access tokens to repositories don't really have repository types. It has a freeform type field, with sensible use this can be used by the repo services