search

reporangler / auth-service

A webservice to handle authentication for repository access
MIT License
0 stars 0 forks source link

Merge XXX_ACCESS and XXX_ADMIN capability types #20

Closed christhomas closed 5 years ago

christhomas commented 5 years ago

It's not really worth having two capabilities for the same thing, but have to also duplicate the logic for dealing with them to know if you're admin or not.

Each capability has a constraint field which is a json object, this could just add an extra field inside it called {"admin": true} and then we can eliminate all the duplicated logic

christhomas commented 5 years ago

This was completed and appears to be working as expected