reportportal / agent-Python-RobotFramework

Robot Framework integration for Report Portal
Apache License 2.0
59 stars 33 forks source link

Changes to disable ssl verification by passing an argument to the listener #126

Closed balak-cv closed 2 years ago

balak-cv commented 3 years ago

this change is to allow disabling ssl verification which isnt well document in reportportal-client and we can pass this as an argument while calling listener, this is really useful when the reportportal is sitting behind an SSL this can be extended to take all the args we can extend to support ReportPortalService class

HardNorth commented 3 years ago

Apart from that successful check passes is a must.

balak-cv commented 3 years ago

Apart from that successful check passes is a must.

sure let me review what @iivanou has asked me to check and then will fix the checks

balak-cv commented 3 years ago

I do not see an ability to pass this flag outside of the agent code. Look at the code that handles passing skipped_issue flag.

thats a much cleaner approach @iivanou , pls check the changes now

HardNorth commented 2 years ago

Abandoned