Fix Cucumber parallel run in ScenarioReporter mode

reportportal / agent-java-cucumber4

Cucumber JVM version [4.0.0; 5.0.0) adapter

Apache License 2.0

6 stars 9 forks source link

Fix Cucumber parallel run in ScenarioReporter mode #13

Closed Susirya closed 4 years ago

Susirya commented 5 years ago

TODO: fix StepReporter mode (but do we really need it?)

fixes:

parallel execution on cucumber_v4+ in ScenarioReporter mode
issue#8(parallel run of Scenario Outlines)

The only drawback is that it corrupts StepReporter mode in the same way as ScenarioReporter was failing - you can not run more then 1 thread. Didn't managed to figure out why yet... But IMHO StepReporter mode in cucumber is useless anyway...

@avarabyeu @DzmitryHumianiuk

DzmitryHumianiuk commented 5 years ago

CC @Yumfriez @ihar-kahadouski for review

evgenytkachenko commented 4 years ago

can we merge it ?

DzmitryHumianiuk commented 4 years ago

@evgenytkachenko i'd expect @HardNorth review here first

evgenytkachenko commented 4 years ago

@HardNorth can you please take a look at it ? I reproduced this issue and it is blocking us with POC of utilizing Report Portal

HardNorth commented 4 years ago

Fixed in: https://github.com/reportportal/agent-java-cucumber4/pull/22