search

reportportal / agent-js-jest

Agent to integrate Jest with ReportPortal.
https://www.npmjs.com/package/@reportportal/agent-js-jest
Apache License 2.0
21 stars 37 forks source link

Update dependencies #125

Closed ghost closed 1 year ago

ghost commented 1 year ago

To be compatible with jest 29 that I use in a project, I had to update some dependencies.

I couldn't easily update strip-ansi since the new version only has an ESM export, so I inlined it and its dependency (it's just two functions anyway).

ghost commented 1 year ago

Actually, you could probably remove the dependencies all together (@jest/reporters) (jest-cli). I don't think they are used

added another commit

AmsterGet commented 1 year ago

Hello @TomKlaverAH ! Thanks for your input. I would prefer external dependencies to be installed from the package registries rather than copied into the codebase in case no modifications are needed. I believe this will help us automatically detect security vulnerabilities based on package versions. So let's bring back strip-ansi with the latest version that supports common-js modules, hopefully this doesn't break compatibility with jest 29.

AmsterGet commented 1 year ago

Hey @TomKlaverAH ! I've updated all deps in the scope of Release 5.0.6, please check. Now there should be no problems with jest 29, so I will close this PR. Thanks for bringing this up.