search

reportportal / agent-python-pytest

Framework integration with PyTest
Apache License 2.0
94 stars 102 forks source link

Adds support to have attributes with same keys #283

Closed san7ket closed 2 years ago

san7ket commented 2 years ago

Report Portal supports having Attributes with same keys. This is important when filtering data on dashboards and having similar attributes on same level. Also helpful in grouping tests.

New Contributor Alert, Please let me know, if there is anything I missed or need to do to have pr reviewed

iivanou commented 2 years ago

Existing unit tests require modifications as well.

san7ket commented 2 years ago

Sorry was away on vacation, will work on comments. thank you.

san7ket commented 2 years ago

@iivanou resolved comments and fixed unit tests.

iivanou commented 2 years ago

@san7ket Tests still have not passed...

san7ket commented 2 years ago

@san7ket Tests still have not passed...

Fixed the flake8 issues, tox now succeeds on py36

san7ket commented 2 years ago

@iivanou tested on py36 , tests should now pass

codecov-commenter commented 2 years ago

Codecov Report

Merging #283 (d0bc127) into master (ba6dde3) will increase coverage by 0.36%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   49.92%   50.28%   +0.36%     
==========================================
  Files           7        7              
  Lines         685      690       +5     
==========================================
+ Hits          342      347       +5     
  Misses        343      343
Flag Coverage Δ
unittests 50.28% <100.00%> (+0.36%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pytest_reportportal/service.py 40.93% <100.00%> (+0.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba6dde3...d0bc127. Read the comment docs.