Closed san7ket closed 2 years ago
Existing unit tests require modifications as well.
Sorry was away on vacation, will work on comments. thank you.
@iivanou resolved comments and fixed unit tests.
@san7ket Tests still have not passed...
@san7ket Tests still have not passed...
Fixed the flake8 issues, tox now succeeds on py36
@iivanou tested on py36 , tests should now pass
Merging #283 (d0bc127) into master (ba6dde3) will increase coverage by
0.36%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 49.92% 50.28% +0.36%
==========================================
Files 7 7
Lines 685 690 +5
==========================================
+ Hits 342 347 +5
Misses 343 343
Flag | Coverage Δ | |
---|---|---|
unittests | 50.28% <100.00%> (+0.36%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
pytest_reportportal/service.py | 40.93% <100.00%> (+0.87%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ba6dde3...d0bc127. Read the comment docs.
Report Portal supports having Attributes with same keys. This is important when filtering data on dashboards and having similar attributes on same level. Also helpful in grouping tests.
New Contributor Alert, Please let me know, if there is anything I missed or need to do to have pr reviewed