search

reportportal / agent-python-pytest

Framework integration with PyTest
Apache License 2.0
95 stars 102 forks source link

Remove `rp_ignore_errors` flag #288

Closed HardNorth closed 2 years ago

HardNorth commented 2 years ago

We are reporting tool we should not fail by default.

Ern-st commented 2 years ago

@HardNorth it would still be nice to be able to set the flag… is it possible to revert this commit and instead set the value to False by default?

HardNorth commented 2 years ago

@Ern-st What is the reason? Other language implementations don't need it.

Ern-st commented 2 years ago

@HardNorth We've had some stability issues with our RP installation and it is crucial that out test suite is run every night, also on weekends when no-one can fix RP

HardNorth commented 2 years ago

@Ern-st it will run, just won't fail. Actually this feature is a part of greater movement toward asynchronous client to mitigate these issues: https://github.com/reportportal/agent-Python-RobotFramework/issues/143 https://github.com/reportportal/agent-python-pytest/issues/204

Ern-st commented 2 years ago

@HardNorth ok, that's good to know 😄

We've experienced some other issues with the 5.1.0 client so we're locking our dependency to 5.0.12 for now 🔒

HardNorth commented 2 years ago

@Ern-st Could you share which issues?

Ern-st commented 2 years ago

@HardNorth my colleague reported the issue and you've already fixed it ❤️ https://github.com/reportportal/client-Python/issues/182

kisscelia commented 2 years ago

We should delete this argument, in this repo file(examples-python -> pytest -> pytest.ini)

HardNorth commented 2 years ago

@kisscelia Done. Thanks for the notice.