reportportal / commons-net

Multithreaded .NET reporter of test results to Report Portal
Apache License 2.0
5 stars 9 forks source link

Provide a way to log file into test #43

Closed nvborisenko closed 2 years ago

nvborisenko commented 4 years ago

Currently user may use:

any_log_framework.Info("my dog {rp#file#" + filePath + "}")` // and then log framework appender tries to conver it to known message

At the same time we have:

ReportPortal.Shared.Log.Info("my message")

What if we have overloaded method to accept FileInfo?

ReportPortal.Shared.Log.Info(new FileInfo(<path_to_the_file>))
nvborisenko commented 4 years ago

This is easier than https://github.com/reportportal/commons-net/issues/27

Aleh-Yanushkevich commented 2 years ago

@nvborisenko Is it still relevant? Because I see overloaded method like: image

nvborisenko commented 2 years ago

yes, we can do something like

void Info(string message, System.IO.FileInfo file)
nvborisenko commented 2 years ago

Resolved in scope of #87