search

reposense / RepoSense

Contribution analysis tool for Git repositories
https://reposense.org
MIT License
251 stars 154 forks source link

[#2177] Migrate to Java 11 Syntax and Features #2183

Closed georgetayqy closed 7 months ago

georgetayqy commented 7 months ago

Part of #2177

Proposed commit message

Our current codebase is written on Java 8, which is around 2
generations behind on the latest supported LTS version for Java.

Let's move to migrate our CI/CD from Java 8 to Java 11 first to prepare
for any upcoming changes in our syntax, APIs and features.

Other information

N/A

supermii2 commented 7 months ago

Adding on to what Ryan has mentioned, we should also consider upgrading checkstyle and other parts that can be done following the migration!

georgetayqy commented 7 months ago

@sopa301 Done! I have updated the docs to reflect the migration from Java 8 to Java 11!

georgetayqy commented 7 months ago

@supermii2 I agree, we should discuss the different components that can be upgraded and begin implementing the changes in this PR!

georgetayqy commented 7 months ago

@supermii2 I have upgraded checkstyle to version 10.10.0 as described in #1304. Do let me know if there are any other areas that need upgrading!

georgetayqy commented 7 months ago

@gok99 I have removed the flag from the build.gradle file. Do let me know if there are any more changes that needs to be made!

ckcherry23 commented 7 months ago

Right now, the status checks are not passing because the branch protection rules require the "JDK 8" version to pass, whereas this PR changes the CI name to use "JDK 11".

Hence, the "Branch protection rules" or "Status checks that are required" settings must be updated to reflect the new name for this PR to be merged.

chan-j-d commented 7 months ago

@ckcherry23 I've updated the branch protection rules to require the new JDK 11 checks instead. Though the frontend tests seem to be failing somewhat randomly, based on the history of CI runs on this PR. Should probably fix that soon and merge this as it breaks the other PRs.

github-actions[bot] commented 7 months ago

The following links are for previewing this pull request: