Closed asdfghjkxd closed 2 months ago
@sopa301 Let me work on that and update you in the upcoming days!
@sopa301 I have implemented new test cases for BlurbMap, please do let me know if there are any other aspects that are lacking in tests!
@gok99 @ckcherry23 I have added the new changes as requested!
The following links are for previewing this pull request:
Thanks @asdfghjkxd for this PR, and @ckcherry23 @gok99 @sopa301 for the reviews/guidance. 💯
Hi prof @damithc, I merged the PR without giving co-author credit to @sopa301 by mistake, but both @asdfghjkxd and @sopa301 were authors of this PR.
Hi prof @damithc, I merged the PR without giving co-author credit to @sopa301 by mistake, but both @asdfghjkxd and @sopa301 were authors of this PR.
Noted @ckcherry23 Thanks both @asdfghjkxd and @sopa301
Hi prof @damithc , the link should be the link to the branch instead of to the repo (because multiple branches from the same repo can be displayed). For example, https://github.com/AY2324S2-CS2103-F08-2/tp/tree/master instead of https://ay2324s2-cs2103-f08-2.github.io/tp/
If you want to configure the blurbs.md to point to the main/master branch if the repo link is specified, we can open an issue for it.
Hi prof @damithc , the link should be the link to the branch instead of to the repo (because multiple branches from the same repo can be displayed). For example, https://github.com/AY2324S2-CS2103-F08-2/tp/tree/master instead of https://ay2324s2-cs2103-f08-2.github.io/tp/
@sopa301 Ah, I see. I missed that part. It's working now after I added the branch. Thanks for the clarification.
If you want to configure the blurbs.md to point to the main/master branch if the repo link is specified, we can open an issue for it.
I guess no need. It's not too much extra work to specify the branch.
Feature in action https://nus-cs2103-ay2324s2.github.io/tp-dashboard
Part of #2170
Proposed commit message
Other information
This feature requires Java 11 CI/CD to be implemented.