search

reposense / RepoSense

Contribution analysis tool for Git repositories
https://reposense.org
MIT License
251 stars 154 forks source link

[#2195] Add cypress test for show tag when grouping by author and by none #2197

Closed jonasongg closed 6 months ago

jonasongg commented 7 months ago

Fixes #2195

Proposed commit message

Add cypress test for show tag when grouping by author and by none

Currently, there are no Cypress tests to test the behaviour of the show
tag feature when the report is grouped by author or grouped by none.

Let's add a test for this to ensure the feature is working properly.

Other information

jonasongg commented 6 months ago

@ckcherry23 the bug with group by none actually happened because of a change I made in this PR to fix group by author. i fixed the bug in this PR already, so all group by options should be working correctly. (also added some tests for this!) do i need to create a new issue + PR to address the original bug?

ckcherry23 commented 6 months ago

@ckcherry23 the bug with group by none actually happened because of a change I made in this PR to fix group by author. i fixed the bug in this PR already, so all group by options should be working correctly. (also added some tests for this!) do i need to create a new issue + PR to address the original bug?

If everything works as expected now, we do not need a new issue + PR. The current PR seems to have fixed all the issues, is there anything missing?

jonasongg commented 6 months ago

@ckcherry23 done, thanks!

github-actions[bot] commented 6 months ago

The following links are for previewing this pull request: