search

reposense / RepoSense

Contribution analysis tool for Git repositories
https://reposense.org
MIT License
251 stars 154 forks source link

[#2196] Use git blame line info for aggregate blame author modified and date info #2232

Open logical-1985516 opened 4 months ago

logical-1985516 commented 4 months ago

Fixes #2196

Proposed commit message

Uses blameLine to abstract away the string wrangling and improve
understandability. Magic numbers are also replaced to improve code
quality.

In order to use blameLine however, it is also changed to use 
author-time instead of commit-time, as there is a discrepancy
between the two, causing some test cases to fail.

The naming of the timestamp field in GitBlameLineInfo is changed
to reflect that it is in seconds, as author-time is in seconds.

Other information

Surrounding code which states milliseconds is also changed to state seconds correctly, as this PR is meant to resolve a code quality issue anyways. If this is not ok, I can revert the last commit.

logical-1985516 commented 4 months ago

Hi, I have noticed that some test cases take a very long time to finish. Could this be due to the additional overhead incurred from running git blame command in blameLine?

logical-1985516 commented 4 months ago

Hi, would anyone like to approve the workflow? I am not sure why the local test cases run indefinitely, so I am unable to verify that it passes all test cases. Thank you!

damithc commented 4 months ago

Hi, would anyone like to approve the workflow? I am not sure why the local test cases run indefinitely, so I am unable to verify that it passes all test cases. Thank you!

done

logical-1985516 commented 4 months ago

Hi, would anyone like to help me for this issue? I could not seem to figure why the test cases are failing. More information at this discussion.

github-actions[bot] commented 2 months ago

Hi, We are going to mark this PR as stale because it has been inactive for the past 30 days. If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label. Do let us know if you are stuck so that we can help you!'

github-actions[bot] commented 2 months ago

This PR was closed because it has been marked as stale for 7 days with no activity. Feel free to reopen this PR if you would like to continue working on it.

gok99 commented 2 months ago

@logical-1985516 Are you planning to wrap up this PR and #2238? I think this PR is mostly good to merge and is just pending some updates to tests.

logical-1985516 commented 2 months ago

Hi @gok99, for this PR, I may be able to wrap up this PR within next week, if I have the time. However, I probably would not wrap up PR #2238. Sorry about that.

gok99 commented 1 month ago

@logical-1985516 thanks for the fixes. made a minor name change.