search

repository-service-tuf / repository-service-tuf-worker

Repository Service for TUF: Worker
MIT License
8 stars 15 forks source link

Task: Improve `_validate_threshold`, so it tells how many more signatures are required #367

Open MVrachev opened 1 year ago

MVrachev commented 1 year ago

Improve _validate_threshold, so it tells how many signatures are required. This will give more information why we fail validation of a metadata. Please keep in mind this will most likely require changes in python-tuf method Metadata.verify_delegate as well.

_Originally posted by @lukpueh in https://github.com/repository-service-tuf/repository-service-tuf-worker/pull/355#discussion_r1304237344_:

That would be great, but it's a bit tricky, because `_validate_threshold` is just a wrapper around 
`Metadata.verify_delegate`, which does not tell us how many signatures 
that counted towards the threshold were verified. 
I suggest to ticketize this. It might actually be an interesting feature in python-tuf.
lukpueh commented 11 months ago

Let's replace _validate_threshold with python-tuf's new get_verification_result for this, once it's released!

https://github.com/theupdateframework/python-tuf/pull/2481

MVrachev commented 10 months ago

This issue is ready to be tackled and it's important. I suggest we do it as early as we can @kairoaraujo and @KAUTH.