repository-service-tuf / repository-service-tuf-worker

Repository Service for TUF: Worker
MIT License
8 stars 15 forks source link

Add AWS KMS support to SignerStore #452

Closed lukpueh closed 6 months ago

lukpueh commented 7 months ago

[EDIT 02/14/24: remove poc/draft status]

Add AWS KMS support to SignerStore and test with localstack (tox -e local-aws-kms)

Change details

Todo

This PR adds a single unit test method, which is ran against a 3rd party service. This doesn't fit into the current test architecture, where 3rd party services are consistently mocked in unit tests, and only included in more comprehensive functional tests.

Please advise how to best test this!

[^1]: ignores preparatory refactor commit and ambient settings whitelist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (714a29d) to head (60e7514). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #452 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 15 15 Lines 1071 1085 +14 ========================================= + Hits 1071 1085 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lukpueh commented 7 months ago

455 changed SignerStore to parse ambient signer settings from Dynaconf and re-export them into an isolated environment. Rebasing required the following changes (squashed into original commit):

lukpueh commented 7 months ago

Now that the important blockers are resolved, I think we can actually treat this as AWS KMS support PR. Let me update the PR title/description and mark this ready for review...