search

repository-service-tuf / repository-service-tuf-worker

Repository Service for TUF: Worker
MIT License
8 stars 15 forks source link

Task: remove LocalKeyvault and refactor SignerStore and it's implementations as a service #465

Open MVrachev opened 3 months ago

MVrachev commented 3 months ago

What is the task about?

After a discussion with @kairoaraujo we agreed when we remove LocalKeyvault implementation and move the SignerStore implementation under repository_service_tuf_worker/services/keyvault to be consistent with storage services.

We can also rename SignerStore to KeyVault as it's still a keyvault service.

We plan to add this change for RSTUF Worker at 1.0.0.

Parent feature

No response

References

No response

Code of Conduct

lukpueh commented 1 month ago

@MVrachev, may I ask what "refactor SignerStore" means?

lukpueh commented 1 month ago

FYI: #507 removes LocalKeyVault.

MVrachev commented 1 month ago

@MVrachev, may I ask what "refactor SignerStore" means?

The phrasing is not correct. I don't remember what refactoring did I mean, but only the move of SignerStore to repository_service_tuf_worker/services/keyvault as a replacement of LocalKeyvault.