WuShell
commented
6 years ago ping? I've seen there is another PR adding py3 support, but it seems both PRs got stuck somehow (still waiting for review on this one...)
Closed WuShell closed 5 years ago
WuShell
commented
6 years ago ping? I've seen there is another PR adding py3 support, but it seems both PRs got stuck somehow (still waiting for review on this one...)
jensens
commented
5 years ago sorry, superseded by #12
WuShell
commented
5 years ago Thanks for taking care of all this @jensens
This pull requests contains the minimum changes to make it work with python 3. I've tried it in a python 3.6.1 env running part of that big code base I'm working on, so far it has worked fine (as good as it was running in a 2.7.13 env).
It uses the future package to keep backwards compatibility with python2.
On a next step I guess it would be nice to:
take a look at how tests are written, as they are some cases where deprecated things like failUnless is used, but for now tests are passing.
run pyflakes/pep8 and fix some of the errors/warnings reported there.
I can go on with that, but I'd like to get some feedback on this one first (thanks!)