mcdonc
commented
12 years ago This looks like great work.
Is there any way I could tweak you into writing enough tests to maintain the 100% statement coverage that the repoze.lru module had before these changes?
$ cd /path/to/checkout/of/repoze.lru
$ /somevirtualenv/bin/python setup.py develop
$ /somevirtualenv/bin/easy_install nose coverage
$ /somevirtualenv/bin/python setup.py nosetests --with-coverageThis will produce a coverage report indicating the untested lines.
Also the tests no longer run under anything but Python 2.7, and the code no longer works under Python 3.2, and this will have to be fixed before a merge. A reasonably easy way to run the full test suite on all platforms is via "tox"
$ cd /path/to/checkout/of/repoze.lru
$ /somevirtualenv/bin/easy_install tox
$ /somevirtualenv/bin/toxThis will attempt to run the tests under Python 2.5, 2.6, 2.7, 3.2, PyPy and Jython, each of which will need to be present on your system (see http://tox.testrun.org/latest/). Note that if it passes on Python 2.5 it will probably pass under Jython and if it passes on 2.7 it will probably pass under PyPy, so if those are too much trouble to install, I wouldn't bother too much. But 2.5, 2.6, 2.7, and 3.2 compatibility are definitely a requisite.
snordhausen
tseaver
Issue #2 (LRUCache will evict entries even though not full) get() does not set self.hand any more, so no entries will be evicted before the cache is really full.
Issue #3 (Repeated pushing of same entry removes other cache entries) LRUCache now checks if the key is already in the cache. If so, no other entries are evicted.
Issue #4 (LRUCache.clock wastes RAM) self.clock was split up into two lists, thereby saving a dict for each cache entry
Issue #6 (LRUCache is not thread safe) self.clear() now atomically resets self.clock_xxx, avoiding the index out of bounds errors when get() or put() were accessing self.clock. Additionally, reading self.hand in put() is now protected by a lock, preventing problems when many threads try to put() simultaneously and need to wait on another that holds the lock
Issue #7 (LRUCache.put() can take multiple seconds on large caches) put() will now check at most 107 entries. This avoids applications from stalling and in the worst case, it will only evict <1% innocent victims. After that, it evicts those items that would have been evicted, anyway.
issue #8 (LRUCache should provide a way to remove items from the cache) A new "invalidate()" method was added.