update to work with newer sphinx

[freddrake]

• avoid sphinx.util.force_decode on python 3.x
• support sphinx 3.x:
  • Sphinx.domains -> Sphinx.registry.domains
  • Sphinx.override_domain(D) -> Sphinx.add_domain(D, override=True)

[icemac]

Is there something needed for this PR to be merged?

[freddrake]

AFAICT, it just needs someone with write access to the repository to pay attention, and someone with release authority to make a release.

[icemac]

@dataflake According to PyPI you are allowed to release this package do you also have the rights to merge?

[dataflake]

@icemac I'm not allowed to merge, no. Ping @tseaver

[freddrake]

Thanks, @tseaver! I'd have been glad to update, but you were too quick!

[tseaver]

@freddrake Actually, I'm having trouble getting the tests to pass with any 2.x version of Sphinx (after the merge):

Test-module import failures:

Module: repoze.sphinx.tests.test_autointerface

Traceback (most recent call last):
  File "/home/tseaver/projects/repoze/src/repoze.sphinx.autointerface/.tox/py35/lib/python3.5/site-packages/repoze/sphinx/tests/test_autointerface.py", line 3, in <module>
    from .util import TestApp
  File "/home/tseaver/projects/repoze/src/repoze.sphinx.autointerface/.tox/py35/lib/python3.5/site-packages/repoze/sphinx/tests/util.py", line 11, in <module>
    from sphinx.ext.autodoc import AutoDirective
ImportError: cannot import name 'AutoDirective'

Test-modules with import problems:
  repoze.sphinx.tests.test_autointerface
Total: 0 tests, 0 failures, 1 errors and 0 skipped in 0.000 seconds.

[freddrake]

Ouch! I should be able to look at this sometime this week, but doesn't look like it'll be today.

[tseaver]

OK, thanks!

[tseaver]

I was going to push changes dropping Python 3.3, 3.4, and adding 3.6, 3.7, and 3.8, but will hold off until we get things passing on master.

[kloczek]

Is it possible to make new release with that commit?

[kloczek]

Just made the test packaging 0.8 + all git commits and found that pytest is failing and on first look it looks like yet another sphinx 4.0.x issue To eproduce that:

• "setup.py build"
• "setup.py install --root </install/prefix>"
• run pytest with PYTHONPATH pointing to sitearch and sitelib inside </install/prefix:

• PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-repoze-sphinx-autointerface-0.8-20.1.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-repoze-sphinx-autointerface-0.8-20.1.fc35.x86_64/usr/lib/python3.8/site-packages
• PYTHONDONTWRITEBYTECODE=1
• /usr/bin/pytest -ra =========================================================================== test session starts ============================================================================ platform linux -- Python 3.8.9, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 benchmark: 3.4.1 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000) rootdir: /home/tkloczko/rpmbuild/BUILD/repoze.sphinx.autointerface-0.8 plugins: forked-1.3.0, shutil-1.7.0, virtualenv-1.7.0, expect-1.1.0, httpbin-1.0.0, xdist-2.2.1, flake8-1.0.7, timeout-1.4.2, betamax-0.8.1, freezegun-0.4.2, case-1.5.3, isort-1.3.0, aspectlib-1.5.2, asyncio-0.15.1, toolbox-0.5, xprocess-0.17.1, aiohttp-0.3.0, checkdocs-2.7.0, mock-3.6.1, rerunfailures-9.1.1, requests-mock-1.9.3, Faker-8.4.0, cov-2.12.1, pyfakefs-4.5.0, cases-3.6.1, flaky-3.7.0, hypothesis-6.14.0, benchmark-3.4.1 collected 1 item / 1 error

================================================================================== ERRORS ================================================================================== ____ ERROR collecting repoze/sphinx/tests/test_autointerface.py ____ ImportError while importing test module '/home/tkloczko/rpmbuild/BUILD/repoze.sphinx.autointerface-0.8/repoze/sphinx/tests/test_autointerface.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /usr/lib64/python3.8/importlib/init.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) ../../BUILDROOT/python-repoze-sphinx-autointerface-0.8-20.1.fc35.x86_64/usr/lib/python3.8/site-packages/repoze/sphinx/tests/test_autointerface.py:3: in from .util import TestApp ../../BUILDROOT/python-repoze-sphinx-autointerface-0.8-20.1.fc35.x86_64/usr/lib/python3.8/site-packages/repoze/sphinx/tests/util.py:11: in from sphinx.ext.autodoc import AutoDirective E ImportError: cannot import name 'AutoDirective' from 'sphinx.ext.autodoc' (/usr/lib/python3.8/site-packages/sphinx/ext/autodoc/init.py) ========================================================================= short test summary info ========================================================================== ERROR repoze/sphinx/tests/test_autointerface.py !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ============================================================================= 1 error in 0.37s =============================================================================

[icemac]

@kloczek Please see the other PRs in this repository trying to fix the problems with Sphinx 4. Any help is appreciated.