reppners / ngx-drag-drop

Angular directives using the native HTML Drag And Drop API

https://reppners.github.io/ngx-drag-drop/

BSD 3-Clause "New" or "Revised" License

311 stars 121 forks source link

Angular 18 support #170

Closed Roozenboom closed 4 months ago

Roozenboom commented 5 months ago

We want are migrating to Angular 18 and when we install the package ngx-drag-drop throws a warning for unmet peer dependency

warning " > ngx-drag-drop@17.0.0" has incorrect peer dependency "@angular/common@^17.0.0". warning " > ngx-drag-drop@17.0.0" has incorrect peer dependency "@angular/core@^17.0.0".

Are there any plans to support Angular 18?

Ookamini95 commented 5 months ago

at the moment I'm using it with --force on 18 and it's working mostly fine (no particular bug found).

MoInMaRvZ commented 5 months ago

I opened a pull request for update to angular 18, https://github.com/reppners/ngx-drag-drop/pull/172

henkkelder commented 4 months ago

@MoInMaRvZ Is there a way I could use your branch?

screambeard commented 4 months ago

Is there anyway I or other can help with this?

egorkel-altexsoft commented 4 months ago

@MoInMaRvZ Is there a way I could use your branch?

You can use github URL instead of version https://docs.npmjs.com/cli/v10/configuring-npm/package-json#github-urls

henkkelder commented 4 months ago

@MoInMaRvZ Is there a way I could use your branch?

You can use github URL instead of version https://docs.npmjs.com/cli/v10/configuring-npm/package-json#github-urls

I think that only works of the repos contains a build version of the package. I don't think is this is the case here.

egorkel-altexsoft commented 4 months ago

Yep, it does not build the lib. Unlucky

Roozenboom commented 4 months ago

v18.0.0