reppners / ngx-drag-drop

Angular directives using the native HTML Drag And Drop API
https://reppners.github.io/ngx-drag-drop/
BSD 3-Clause "New" or "Revised" License
307 stars 120 forks source link

Angular 6 upgrade #21

Closed mtraynham closed 5 years ago

mtraynham commented 6 years ago

I gave it an initial pass, but I'm not entirely clear on how the angular-cli works or how it's set up with this project.

reppners commented 6 years ago

I've yet to look at the details of how angular cli v6 does it, but it should be just some "rewiring" of how it works at the moment. Angular cli's library support is based on ng-packagr which is already used now to make the library build for this project.

Relevant angular cli docs concerning libraries https://github.com/angular/angular-cli/wiki/stories-create-library

I've not yet tested if the currently released library build works in v6 as is. Will setup a stackblitz to see if it works.

reppners commented 6 years ago

Setup a issue template StackBlitz, seems like the library works fine with angular v6.

https://stackblitz.com/edit/ngx-drag-drop-issue-template

reppners commented 5 years ago

Jumped straight to ng v7