search

reppners / ngx-drag-drop

Angular directives using the native HTML Drag And Drop API
https://reppners.github.io/ngx-drag-drop/
BSD 3-Clause "New" or "Revised" License
307 stars 120 forks source link

Support angular 7 #49

Closed sebek64 closed 5 years ago

sebek64 commented 5 years ago

Describe the bug Angular 7 is currently not formally supported. A warning is produced:

warning " > ngx-drag-drop@2.0.0-rc.3" has incorrect peer dependency "@angular/core@^4.0.0 || ^5.0.0 || ^6.0.0".

reppners commented 5 years ago

Thanks for reporting. So far my (quick) tests prove Angular 7 compatibility but I'd rather test some more before releasing a new version with formal Angular 7 support.

dev-ps23 commented 5 years ago

Angular 7 has CDK's drag drop module integrated. Maybe use ngx-drag-drop as wrapper for it in angular 7. BTW thanks for this wonderful package <3 . :-)

alecrt commented 5 years ago

Any news on Angular 7 version?

VigneshVaidyanathan commented 5 years ago

I am using Angular 7 and I am not facing any issues or warning. It works as in the example but I am trying without the Angular Material.

reppners commented 5 years ago

Updated build and demo to use angular 7. It always worked without issues but I guess this makes it kind of official 🤔 😄