reprappro / Marlin

Reprap FW with look ahead. SDcard and LCD support. It works on Gen6, Ultimaker, RAMPS and Sanguinololu
46 stars 66 forks source link

X and Y axes were reversed after firmware update #15

Closed krolco closed 11 years ago

krolco commented 11 years ago

I have a RepRapPro Mendel Legacy machine. After updating the firmware using your latest code, the directions of the X and Y axes were reversed. The directions of the extruder and Z axes were OK.

reprappro commented 11 years ago

Hi, This change is deliberate and was made necessary by the fact that we have simplified the wiring. It is easy to change the direction of the axes in this section of code in the file configuration.h

ifdef REPRAPPRO_MENDEL

define AXES_MAX_LENGTHS {210, 210, 90}

define INVERT_X_DIR false // for Mendel set to false, for Orca set to true

define INVERT_Y_DIR true // for Mendel set to true, for Orca set to false

define INVERT_Z_DIR false // for Mendel set to false, for Orca set to true

define INVERT_E0_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

define INVERT_E1_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

define INVERT_E2_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

endif

ifdef REPRAPPRO_MENDEL2

define AXES_MAX_LENGTHS {210, 210, 140}

define INVERT_X_DIR true // for Mendel set to false, for Orca set to true

define INVERT_Y_DIR true // for Mendel set to true, for Orca set to false

define INVERT_Z_DIR false // for Mendel set to false, for Orca set to true

define INVERT_E0_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

define INVERT_E1_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

define INVERT_E2_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

endif

ifdef REPRAPPRO_HUXLEY

define AXES_MAX_LENGTHS {155, 150, 90}

define INVERT_X_DIR false // for Mendel set to false, for Orca set to true

define INVERT_Y_DIR false // for Mendel set to true, for Orca set to false

define INVERT_Z_DIR false // for Mendel set to false, for Orca set to true

define INVERT_E0_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

define INVERT_E1_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

define INVERT_E2_DIR true // for direct drive extruder v9 set to true, for geared extruder set to false

8

Best wishes Adrian

krolco commented 11 years ago

Hi Adrian,

I did figure that out before I made the pull request -- the pull request was for the 86cc change which reversed those axes in the config, because I figured it would affect other Legacy users also. Thanks for following up with me.

However, I am a github n00b, so my pull request has additional commits that should be there, so I will figure that out. In any case, though, since the configuration has conditional compilation for Legacy owners, I thought it would be use to reverse the axes in the Legacy section.

Thank you!