search

reprappro / RepRapFirmware

OO C++ RepRap Firmware
Other
143 stars 120 forks source link

Change MAC address input format #66

Closed jstck closed 9 years ago

jstck commented 10 years ago

Set the base of strtol to 16 when parsing MAC address. This means the address can be specified in the much more human-friendly format

M540 PBE:EF:12:34:56:78

The variant with "0x" preceding each byte still works just as earlier, this small change just makes the 0x optional.

RRP-support commented 10 years ago

Hi jstck, thanks for your help! Though it's up to Adrian to integrate this sort of change, he's in charge of the firmware. Ian, RepRapPro tech support

jstck commented 10 years ago

Certainly. A github pull request just seemed like a reasonable idea to explain what I meant, and I fully expect Adrian to scrutinize it. ;) I sent the same thing to dc42, and he also suggested it would be good to replace strtol() with strtoul() to always get an unsigned value back. Does actually not matter unless someone really tries to break it, but still...

/John

On Mon, Aug 18, 2014 at 11:45 PM, RRP-support notifications@github.com wrote:

Hi jstck, thanks for your help! Though it's up to Adrian to integrate this sort of change, he's in charge of the firmware. Ian, RepRapPro tech support

— Reply to this email directly or view it on GitHub https://github.com/reprappro/RepRapFirmware/pull/66#issuecomment-52559894 .

reprappro commented 10 years ago

Hi John,

Thanks for that. I've just put it in Version 90 in the dev branch.

Best wishes

Adrian

Dr Adrian Bowyer Director http://reprappro.com

On 18/08/14 23:18, John Stäck wrote:

Certainly. A github pull request just seemed like a reasonable idea to explain what I meant, and I fully expect Adrian to scrutinize it. ;) I sent the same thing to dc42, and he also suggested it would be good to replace strtol() with strtoul() to always get an unsigned value back. Does actually not matter unless someone really tries to break it, but still...

/John

On Mon, Aug 18, 2014 at 11:45 PM, RRP-support notifications@github.com wrote:

Hi jstck, thanks for your help! Though it's up to Adrian to integrate this sort of change, he's in charge of the firmware. Ian, RepRapPro tech support

— Reply to this email directly or view it on GitHub

https://github.com/reprappro/RepRapFirmware/pull/66#issuecomment-52559894 .

— Reply to this email directly or view it on GitHub https://github.com/reprappro/RepRapFirmware/pull/66#issuecomment-52563701.