search

reprappro / RepRapFirmware

OO C++ RepRap Firmware
Other
143 stars 120 forks source link

Properly initialise missing keys in local storage when loading settings. #76

Closed OlegGirko closed 9 years ago

OlegGirko commented 9 years ago

Some keys expected by updated JavaScript are missing when loading settings from local storage after upgrading firmware to version 1.04. For example, storage.get('temps', 'head1') returns undefined, causing problems during further JavaScript initialisation.

This problem manifests as "Connect" button disabled after updating firmware and corresponding files on SD card to version 1.04.

This change refactors local storage load to check for missing keys individually and set default values for missing keys only.

jmgiacalone commented 9 years ago

Hello Oleg, Thanks for submitting this fix. We will accept this change to MASTER this time, but in future, please direct pull requests to the TEST branch. We are the process of tidying our branches in line with https://github.com/reprappro/RepRapFirmware/wiki/Release-procedure.

RRP-support commented 9 years ago

This is an automated reply to your message "Re: [RepRapFirmware] Properly initialise missing keys in local storage when loading settings. (#76)" sent to support@reprappro.com.

Dear jmgiacalone notifications@github.com

Thank you for your email. We endeavour to answer all emails within 24 hours. It may take longer during busy times, and holiday periods. We process all customer queries on a first come first served basis, during our office hours which are 9am to 5pm GMT Mon-Fri.

Other support channels are available. Please refer to the relevant troubleshooting guide for your machine:

Ormerod 2: https://reprappro.com/documentation/ormerod-2/troubleshooting/ Ormerod: https://reprappro.com/documentation/ormerod/troubleshooting/

Huxley Duo: https://reprappro.com/documentation/huxley-duo/troubleshooting/ Huxley: https://reprappro.com/documentation/huxley/troubleshooting/

Mono and Tricolour Mendel: https://reprappro.com/documentation/mendel-tricolour/troubleshooting/

Support is also available from other owners of RepRapPro and other 3D printers, either through the RepRap Forums: https://forums.reprap.org or through IRC which can be accessed from here: https://reprappro.com/support-channel/ (works on Chrome, not Firefox).

Best regards,

RepRapPro Support Team.